Skip to content

[MDS-6561] Notice of Departure Issues#3578

Merged
taraepp merged 1 commit intodevelopfrom
mds-6561-nod
Jun 23, 2025
Merged

[MDS-6561] Notice of Departure Issues#3578
taraepp merged 1 commit intodevelopfrom
mds-6561-nod

Conversation

@taraepp
Copy link
Contributor

@taraepp taraepp commented Jun 20, 2025

Objective

  • turns out you could submit- there was just a form item that was shown as optional that was actually required.
  • passed in isModal so the cancel button closes it
  • with EditNoticeOfDepartureModal the component was misnamed and had unused props/function, so tidied that up
  • the modalConfig for the Add modal was irritating me so I deleted it.

MDS-6561

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@taraepp taraepp merged commit 43bee92 into develop Jun 23, 2025
12 checks passed
@taraepp taraepp deleted the mds-6561-nod branch June 23, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants