[MDS-6594] Permit conditions ordering bug in search#3605
Merged
Conversation
|
asinn134
requested review from
matbusby-fw,
sggerard,
simensma-fresh and
taraepp
simensma-fresh
approved these changes
Jul 22, 2025
taraepp
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
MDS-6594
context_enricher.pyinside therunfunction and the_format_context_chainfunction when it was formatting the list of siblings it was splitting the list in half by 2 to get the mid. but in our case using whatever position the current document object we are looking at as the mid should work better. If we use the position of the current document object we can better split the siblings list into the two sections ofpreviousandnextto get an accurate ordering.