Skip to content

[MDS-6634] Conflict between "Add Report Requirement" form and condition form#3661

Merged
simensma-fresh merged 1 commit intodevelopfrom
mds-6634-closeform-edit
Sep 3, 2025
Merged

[MDS-6634] Conflict between "Add Report Requirement" form and condition form#3661
simensma-fresh merged 1 commit intodevelopfrom
mds-6634-closeform-edit

Conversation

@taraepp
Copy link
Contributor

@taraepp taraepp commented Aug 28, 2025

Objective

  • currently, adding a report requirement to a condition with unsaved changes will revert those changes
    • not just because the form closes, but also because of the refreshing data function (which is a whole can of worms)
  • as a solution, added a popconfirm when the condition form is dirty and the user clicks to add a report
  • also, because users lose their place, not closing out the condition form after changes are saved
    • this is kind of an experiment to see if they like it better this way. Pretty easy to revert.
    • makes it easy for adding a report later,
    • and then they can just click another condition to edit it if they like (they don't have to click the X button to close editing if they're truly done)

MDS-6634

Why are you making this change? Provide a short explanation and/or screenshots
image

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@simensma-fresh simensma-fresh merged commit 3e3aab1 into develop Sep 3, 2025
16 checks passed
@simensma-fresh simensma-fresh deleted the mds-6634-closeform-edit branch September 3, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants