Conversation
taraepp
commented
Sep 22, 2025
| services/common/reports/test-reporter.xml | ||
| - name: Sonar Reporting | ||
| uses: SonarSource/sonarcloud-github-action@v2.1.1 | ||
| uses: SonarSource/sonarqube-scan-action@v6.0.0 |
Contributor
Author
There was a problem hiding this comment.
For future reference/git-blaming: old action was running into Node.js error and going to its page, said it was deprecated and to use sonarqube-scan-action instead. 6.0.0 is the current newest version.
taraepp
commented
Sep 22, 2025
| $lightest-grey: #f4f0f0; | ||
| $lightest-grey-alt: #f8f7f7; | ||
| $light-grey-cool: #F7F8FA; | ||
| $light-mid-grey: #e6e8ec; |
Contributor
Author
There was a problem hiding this comment.
seriously running out of names to call new shades of grey. 😂
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
MDS-6651
MineSpace:
(I tweaked the line-height after taking this screenshot, so the space in the "Permit Type" column now matches Core)
(General table changes)
Core:
(Straight up "violet" on the collapse bar looked awful so picked a different variant. Basically same as MS)
(General table. Aside from spacing just changed the sorted column header BG colour because it was blending badly with its neighbours)