Skip to content

[CHORE] Consolidate customAxios files, and a couple of others#3687

Merged
taraepp merged 1 commit intodevelopfrom
chore-consolidate-axios-files
Oct 2, 2025
Merged

[CHORE] Consolidate customAxios files, and a couple of others#3687
taraepp merged 1 commit intodevelopfrom
chore-consolidate-axios-files

Conversation

@taraepp
Copy link
Contributor

@taraepp taraepp commented Sep 25, 2025

Objective

  • use one customAxios file, not five
  • in the process of updating imports, found that there were a few other related files that could also be easily consolidated (that is, already existed in services/common, no huge diffs)
    • RequestHeaders I changed from js -> tsx in ms/core and did an import/export, because they're referenced very specifically in config files (but now point to the same code)
    • DocumentLink --> the one in common has a title on the element which was a change but an obvious improvement (this is the couple of snap changes)
    • actionlessNetworkCalls
    • DocumentColumns
  • did not do helpers.ts because a quick find + replace was about 137 files changed.
    • minespace has 2 of these, with one only including formatDate (where it formats it differently if it's 9999-12-31). Oof

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@taraepp taraepp merged commit 7475984 into develop Oct 2, 2025
17 checks passed
@taraepp taraepp deleted the chore-consolidate-axios-files branch October 2, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants