Skip to content

[MDS-6629] Mines Act Application uploaders#3706

Merged
matbusby-fw merged 4 commits intodevelopfrom
mds-6629-ma-application-uploaders
Oct 20, 2025
Merged

[MDS-6629] Mines Act Application uploaders#3706
matbusby-fw merged 4 commits intodevelopfrom
mds-6629-ma-application-uploaders

Conversation

@taraepp
Copy link
Contributor

@taraepp taraepp commented Oct 16, 2025

Objective

  • basically add a subcategory to mines act applications

KNOWN ISSUE

  • gosh I really don't like how we have those xref objects attached to mine documents that sometimes has category info, but also sometimes it's somewhere else completely different (without a consistent name!)
  • but it felt seriously out of scope to fix it
  • Suggestion for the future: rework mine document BE & FE
    • all those object_xref with object_type_code properties? That only show up for archived documents? category_code. Put it in a hybrid property. Return a simpler object. Have another one that indicates the object type if necessary.
    • and then same for returning major mine application documents- use those same property names so it's like object_code: MMA, category_code: APX, subtype_code: BIF
    • so we can treat all documents the same, but also know what kind of document it is when we need to filter
    • I wrote some really gnarly code and I was not happy about it. It works, but...

MDS-6629

Why are you making this change? Provide a short explanation and/or screenshots

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_minespace-web'

Failed conditions
60.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
78.6% Coverage on New Code (required ≥ 80%)
42.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'

Failed conditions
75.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'

Failed conditions
71.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@matbusby-fw matbusby-fw merged commit d040601 into develop Oct 20, 2025
16 of 20 checks passed
@matbusby-fw matbusby-fw deleted the mds-6629-ma-application-uploaders branch October 20, 2025 21:06
matbusby-fw added a commit that referenced this pull request Nov 5, 2025
* FE, BE, DB changes to allow for subtype/label

* archived docs section

* update migration

* Remove console log

---------

Co-authored-by: Mat.Busby <mat.busby@ca.ey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants