[MDS-6696] Show expired party appointments in mine contacts#3726
Merged
matbusby-fw merged 4 commits intodevelopfrom Nov 5, 2025
Merged
[MDS-6696] Show expired party appointments in mine contacts#3726matbusby-fw merged 4 commits intodevelopfrom
matbusby-fw merged 4 commits intodevelopfrom
Conversation
…ded typing to interfaces and modernized function components for better maintainability.
… improved typing, and modernized component structures.
…st maintainability.
matbusby-fw
added
the
👍 Ready for review
taraepp
reviewed
Nov 4, 2025
| (x.mine_party_appt_type_code !== "DAM" && x.mine_party_appt_type_code !== "CCS") | ||
| ) | ||
| .map((value) => ( | ||
| <Menu.Item key={value.mine_party_appt_type_code}> |
Contributor
There was a problem hiding this comment.
Would love to get rid of Menu.Item in this file and MineHeader if possible.... copilot should make quick work of those
|
|
|
taraepp
approved these changes
Nov 5, 2025
matbusby-fw
added a commit
that referenced
this pull request
Nov 5, 2025
* Refactor mine dashboard and related components to use Redux hooks. Added typing to interfaces and modernized function components for better maintainability. * Refactor mine components to enhance maintainability with Redux hooks, improved typing, and modernized component structures. * Refactor `MineHeader` snapshot to remove outdated data and improve test maintainability. * Refactored Menu.Items into newer format, removed unused test state --------- Co-authored-by: mat <matbusby@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Contacts that had passed their end date and had no new assignment in Core were not visible previously.
Added a section to the mine contacts to display all expired appointments
TS refactors from JS which uncovered some messy stuff that needed clean up
MDS-6696