[MDS-6527] Email/notification updates for final applications#3751
[MDS-6527] Email/notification updates for final applications#3751
Conversation
|
|
||
| return errors_found | ||
|
|
||
| def send_status_notification(self, prev_status, mine): |
There was a problem hiding this comment.
just moved this from the resource file, basically, and then added the bit with noun and final elif if in there
| info_block('Mine Number', project.mine_no) + | ||
| info_block('Project Title', project.project_title) + | ||
| info_block('Submitted', project.submitted), align='center', brand=brand) }} | ||
| info_block('Submitted', project.submitted), brand=brand) }} |
There was a problem hiding this comment.
I don't like the centre align. 🤷♀️
| class Params: | ||
| minimal = factory.Trait( | ||
| mine_no=None, | ||
| mine_no='123456', |
There was a problem hiding this comment.
also never like how test emails go out like "Mine No: " because I'm not sure if it's working properly, so put in a default value here. And made the AmsFinalApplication factory use the correct authorization type below. 😅
| assert put_resp.status_code == 200 | ||
| assert put_resp_data['editable'] == False | ||
|
|
||
| put_data2 = { |
There was a problem hiding this comment.
I was getting all test emails with the ams application being locked which was throwing me off, so added in this bit to make sure it worked right when it's unlocked.
services/core-api/app/api/projects/ams_final_application/models/ams_final_application.py
Outdated
Show resolved
Hide resolved
matbusby-fw
left a comment
matbusby-fw
left a comment
There was a problem hiding this comment.
Looks good. Just noticed one tiny grammar thing
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
2 similar comments
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
3 participants
Objective
MDS-6527
Why are you making this change? Provide a short explanation and/or screenshots