Skip to content

[MDS-6881] Relaxed permit required reports filter#3881

Merged
matbusby-fw merged 2 commits intodevelopfrom
mds-6881-permit-required-reports-not-showing
Apr 6, 2026
Merged

[MDS-6881] Relaxed permit required reports filter#3881
matbusby-fw merged 2 commits intodevelopfrom
mds-6881-permit-required-reports-not-showing

Conversation

@matbusby-fw
Copy link
Copy Markdown
Collaborator

@matbusby-fw matbusby-fw commented Apr 2, 2026

Objective

It looks like the recent update to filter reports was a bit too restrictive. It was filtering permit required reports to only those associated with the latest permit amendment.

relaxed the filter in
services/core-api/app/api/mines/reports/report_helpers.py
to:

  • Always show Code Required Reports (CRR).
  • Show historical PRR submissions (any report with a status other than 'NON').
  • Show legacy standard PRR requirements (where permit_amendment_id is null).
  • Strictly filter unsubmitted PRR requirements (status 'NON') to only those associated with the latest permit amendment.

MDS-6881

Why are you making this change? Provide a short explanation and/or screenshots

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 2, 2026

@matbusby-fw matbusby-fw merged commit 816a6b2 into develop Apr 6, 2026
14 checks passed
@matbusby-fw matbusby-fw deleted the mds-6881-permit-required-reports-not-showing branch April 6, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants