Skip to content

[MDS-6885] [MS] Remove Major Mine Alert Banner for PRP's#3887

Merged
alazar-aot merged 2 commits intodevelopfrom
MDS-6885-Remove-Major-Mine-Alert-Banner-for-PRPs
Apr 17, 2026
Merged

[MDS-6885] [MS] Remove Major Mine Alert Banner for PRP's#3887
alazar-aot merged 2 commits intodevelopfrom
MDS-6885-Remove-Major-Mine-Alert-Banner-for-PRPs

Conversation

@alazar-aot
Copy link
Copy Markdown
Collaborator

Objective

  • Remove the Alert/Banner that was displayed for major mines (major_mine_ind = true), warning them that MMO cannot receive Permit Required Reports (PRP's) through minespace
  • NOTE: No snaps were updated, as the Alert component had never been rendered as part of the snap test, thus removing it did not change the .snap file
  • Also resolved an error with the M1 docker-compose file, where the platform had been specified at the wrong level of the yaml file for the postgres service

MDS-6885

Why are you making this change? Provide a short explanation and/or screenshots

  • See the below changes, showing the banner has been removed:
image

@alazar-aot alazar-aot changed the title MDS-6885 [MS] Remove Major Mine Alert Banner for PRP's [MDS-6885] [MS] Remove Major Mine Alert Banner for PRP's Apr 15, 2026
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link
Copy Markdown

@sonarqubecloud
Copy link
Copy Markdown

@alazar-aot alazar-aot added the 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. label Apr 16, 2026
Copy link
Copy Markdown
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take that you stupid banner!

@alazar-aot alazar-aot merged commit fea6a13 into develop Apr 17, 2026
16 of 18 checks passed
@alazar-aot alazar-aot deleted the MDS-6885-Remove-Major-Mine-Alert-Banner-for-PRPs branch April 17, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants