[CHORE] - Fix NRIS Deploy#3904
Merged
Merged
Conversation
matbusby-fw
changed the title
alazar-aot
previously approved these changes
May 11, 2026
simensma-fresh
requested changes
May 11, 2026
Collaborator
simensma-fresh
left a comment
simensma-fresh
left a comment
There was a problem hiding this comment.
If possible, let's pin the version in requirements.txt instead, and pin to an exact version 🙃
…in backend Dockerfiles
matbusby-fw
commented
May 11, 2026
|
|
||
| # Install the requirements | ||
| COPY requirements.txt . | ||
| ENV PIP_CONSTRAINT=requirements.txt |
Collaborator
Author
There was a problem hiding this comment.
setting PIP_CONSTRAINT to pip forces isolated build environments (which are used when building old packages like cx_Oracle) to honor the version limits defined in the requirements file
simensma-fresh
requested changes
May 11, 2026
| @@ -1,5 +1,5 @@ | |||
| cached_property==1.5.1 | |||
| setuptools | |||
| setuptools<70.0.0 | |||
Collaborator
There was a problem hiding this comment.
Can we pin it to the version we want? ==
There's been too many vulnerabilities lately that stem from dynamic resolution 😅
simensma-fresh
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
PR to fix the deployment of NRIS after recent python upgrades
Why are you making this change? Provide a short explanation and/or screenshots