26519 - Fixed Coop Continuation In NRs#818
Conversation
JazzarKarim
requested review from
EPortman,
eve-git,
flutistar,
mengdong19,
ozamani9gh,
rarmitag,
shaangill025 and
stevenc987
as code owners
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-818-u33totip.web.app Try NR 0180626. Phone is 1234. |
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-818-u33totip.web.app |
severinbeauvais
left a comment
severinbeauvais
left a comment
There was a problem hiding this comment.
The preview site currently shows different phone numbers from your initial screenshot...?
|
/gcbrun |
Should be good now, thank you Sev! |
|
Temporary Url for review: https://namerequest-dev--pr-818-u33totip.web.app |
| val: '250-370-1033', | ||
| href: 'tel:+1-250-370-1033' | ||
| val: '250-387-7848', | ||
| href: 'tel:+1-250-387-7848' |
There was a problem hiding this comment.
I think there are, in fact, separate phone numbers for different pages. Please ask J or J about it.
There was a problem hiding this comment.
They're both away today so I'll leave this here until Monday to verify.
There was a problem hiding this comment.
Confirmed, these numbers are correct here.
FYI: 370-1033 is the help desk. For the continuation in, they need to contact BC Registries Staff, not the help desk, so this is why these numbers are correct here.
There was a problem hiding this comment.
So the same phone number can be used in all 3 places?
There was a problem hiding this comment.
OK, I fixed the component a bit and made it much more flexible. According to Janis, we want to keep the help desk number for alterations. This should be good now, thanks Sev.
There was a problem hiding this comment.
Awesome. Thanks! Resolving.
severinbeauvais
left a comment
severinbeauvais
left a comment
There was a problem hiding this comment.
LGTM. After merging, please follow up with Names Team to tag this to their next release.
4 participants
Issue #: /bcgov/entity#26519
Description of changes:
Implemented the continuation in show contact info
Design: https://www.figma.com/design/QTT8S3jXqz4dtLCcTbsSIm/Coop-Redirection?node-id=2001-7&p=f&m=dev
Added HTML comments to improve code readability
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).