26478-Name validations are not applied in edit mode.#820
Merged
stevenc987 merged 1 commit intobcgov:mainfrom May 7, 2025
stevenc987:main
Merged
26478-Name validations are not applied in edit mode.#820stevenc987 merged 1 commit intobcgov:mainfrom stevenc987:main
stevenc987 merged 1 commit intobcgov:mainfrom
stevenc987:main
Conversation
Signed-off-by: Chen <Steven.Chen@gov.bc.ca>
stevenc987
requested review from
EPortman,
eve-git,
flutistar,
mengdong19,
ozamani9gh,
rarmitag and
shaangill025
as code owners
EPortman
approved these changes
May 7, 2025
Contributor
EPortman
left a comment
EPortman
left a comment
There was a problem hiding this comment.
Looks good.
There are a lot of changes to the package-lock.json though. Was there a reason you updated all of those deps (22,104 changes)?
Collaborator
Author
|
It seems VS codes changed them instead of myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity###
Description of changes:
Uncommented blocks by the desigetionAtEnd and added key words checked for the name choices
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).