Feature/12854 #158
Merged
Feature/12854 #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #158 +/- ##
===========================================
+ Coverage 98.08% 100.00% +1.91%
===========================================
Files 42 42
Lines 366 243 -123
Branches 2 0 -2
===========================================
- Hits 359 243 -116
+ Misses 7 0 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
seeker25
reviewed
Jul 8, 2022
|
|
||
| const quantityRules = [ | ||
| v => !!v || 'This field is required', | ||
| v => (v > 0) || 'Quantity should be grater than 0' |
seeker25
reviewed
Jul 8, 2022
| { | ||
| "name": "fas-ui", | ||
| "version": "1.0.2", | ||
| "version": "1.0.3", |
Collaborator
There was a problem hiding this comment.
might want to bump this to 1.0.6 to match the github release version - I know we're missing a few versions to correlate with the release.
Contributor
Author
There was a problem hiding this comment.
I think we don't want to increase the version number like that. when multiple PR comes with versions, it will not keep up with release version
Collaborator
|
Also this handles Also this handles https://www.github.com/bcgov/entity/issues/9233 ( I put it in the description) |
seeker25
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#12854
Issue #: /bcgov/entity#8948
Issue #: /bcgov/entity#9233
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).