chore: LZA move and tf modules #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
DerekRoberts
approved these changes
Jun 28, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the existing flat Terraform configurations into reusable modules, updates frontend and API stacks to consume those modules, and adjusts CI/CD workflows to align with the new module outputs and tool versions.
- Introduce and wire up new Terraform modules for WAF, S3 buckets, CloudFront, API Gateway, networking, and common resources
- Migrate inline resource definitions in
infrastructure/frontend,infrastructure/api, andinfrastructure/databaseto module calls - Update GitHub Actions workflows and the initial setup script with new Terragrunt/Terraform versions, ECR publishing steps, and module-based outputs
Reviewed Changes
Copilot reviewed 46 out of 47 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| infrastructure/modules/common/variables.tf | Defines target_env but error_message lists values not allowed by the condition |
| infrastructure/modules/networking/variables.tf | Declares availability_zones and security_group_name_suffix yet they’re no longer used |
| infrastructure/modules/networking/main.tf | Hardcodes AZ and SG names, ignoring the declared variables |
| .github/workflows/.deploy_stack.yml | Adds an ecr job to build and push images before other deployment steps |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.