feat: migrate ESLint to flat config #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes backend ESLint migration from PR #199 to fix broken renovate/major-linters branch.
- Create eslint-base.config.mjs with shared rules and ignore patterns - Update backend/eslint.config.mjs to import from shared base - Update frontend/package.json: remove legacy configs (eslint-config-love, import resolvers, promise, import plugins) - Add ESLint 9 flat config dependencies (@eslint/eslintrc, @eslint/js, globals) - Update ESLint and TypeScript ESLint to match root versions (9.16.0, 8.16.0) - Create frontend/eslint.config.mjs with React support and import from base - Preserve all existing React rules from .eslintrc.yml - Remove frontend/.eslintrc.yml and frontend/.eslintignore - Split lint scripts: lint (check-only) and lint:fix (auto-fix) - Update package-lock.json files Part of multi-PR ESLint migration plan.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project's ESLint configuration from the legacy .eslintrc format to the modern flat config format (eslint.config.mjs), along with updating ESLint and related dependencies to their latest versions.
- Migrates from ESLint v8/legacy config to ESLint v9 with flat config format
- Updates TypeScript ESLint packages from v7 to v8
- Consolidates common ESLint configuration into a shared base config file
- Updates related ESLint plugins and removes deprecated dependencies
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package-lock.json | Updates eslint-config-prettier from ^9.1.0 to ^10.0.0 in root package |
| frontend/package.json | Updates ESLint dependencies to v9, TypeScript ESLint to v8, and adds new linting scripts |
| frontend/package-lock.json | Reflects dependency updates including ESLint v9, removes obsolete packages like eslint-config-love |
| frontend/eslint.config.mjs | New flat config format for frontend with React-specific rules |
| frontend/.eslintrc.yml | Removed legacy YAML configuration file |
| frontend/.eslintignore | Removed legacy ignore file (now handled in flat config) |
| eslint-base.config.mjs | New shared base ESLint configuration for both frontend and backend |
| backend/package.json | Updates ESLint dependencies, removes lint-staged and unused plugins |
| backend/eslint.config.mjs | New flat config format for backend with Node-specific settings |
Files not reviewed (1)
- frontend/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 10 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- frontend/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DerekRoberts
changed the title
DerekRoberts
deleted the
feat/frontend-eslint-flat-config-shared-base-main
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrates both backend and frontend from legacy ESLint configurations to ESLint 9.x flat config format with a shared base configuration. This fixes the broken
renovate/major-lintersbranch and enables it to be merged.Changes
eslint-base.config.mjsat root with shared rules and ignore patternseslint-config-airbnb-base,eslint-config-standard, etc.backend/eslint.config.mjsimporting from shared baseeslint-config-love, import resolvers, etc.frontend/eslint.config.mjswith React supportfrontend/.eslintrc.ymlandfrontend/.eslintignorelint(check-only) andlint:fix(auto-fix) in both backend and frontendBenefits
renovate/major-lintersbranch (can now merge to main)Testing
npm cicompletes successfully in both backend and frontendnpm run lintworks in both directoriesRelated
Combines PR #199 (backend) and PR #200 (frontend) into a single PR targeting main directly.