fix: image retags and concurrency #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces concurrency controls to prevent overlapping workflow runs and refactors the image retag jobs to run across a matrix of package types.
- Add top-level
concurrencyblocks in bothrelease.ymlandmerge.yml - Define a
strategy.matrixto retag images forbackend,migrations, andfrontend - Update the
repositoryfield in retag steps to include${{ matrix.package }}
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/release.yml | Added concurrency settings and a matrix strategy for retag jobs |
| .github/workflows/merge.yml | Added concurrency settings and a matrix strategy for retag jobs |
| workflow_dispatch: | ||
|
|
||
| concurrency: | ||
| group: main |
There was a problem hiding this comment.
Using a generic concurrency group name 'main' will prevent workflows across different triggers (e.g., merge and release) from running concurrently. Consider incorporating the workflow name and/or branch in the group expression (e.g., ${{ github.workflow }}-${{ github.ref }}) to scope locks per workflow.
Suggested change
| group: main | |
| group: ${{ github.workflow }}-${{ github.ref }} |
Collaborator
Author
There was a problem hiding this comment.
it is by design, dont want to run them parallel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.