Skip to content

fix: image retags and concurrency #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025
Merged

fix: image retags and concurrency #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .github/workflows/merge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
name: Merge

concurrency:
group: main
cancel-in-progress: false
# This concurrency group ensures that only one workflow runs at a time for the main branch.
on:
push:
branches: [main]
Expand Down Expand Up @@ -47,12 +51,15 @@ jobs:
name: Retag Images Dev
needs: [deploy_stack_dev, vars]
runs-on: ubuntu-24.04
strategy:
matrix:
package: [backend, migrations, frontend]
steps:
- name: retag
uses: shrink/actions-docker-registry-tag@f04afd0559f66b288586792eb150f45136a927fa # v4
with:
registry: ghcr.io
repository: ${{ github.repository }}
repository: ${{ github.repository }}/${{ matrix.package }}
target: ${{ needs.vars.outputs.pr }}
tags: |
dev
Expand All @@ -77,12 +84,15 @@ jobs:
name: Retag Images Test
needs: [deploy_stack_test, vars]
runs-on: ubuntu-24.04
strategy:
matrix:
package: [backend, migrations, frontend]
steps:
- name: retag
uses: shrink/actions-docker-registry-tag@f04afd0559f66b288586792eb150f45136a927fa # v4
with:
registry: ghcr.io
repository: ${{ github.repository }}
repository: ${{ github.repository }}/${{ matrix.package }}
target: ${{ needs.vars.outputs.pr }}
tags: |
test
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
name: PROD
on:
workflow_dispatch:

concurrency:
group: main
Copy link

Copilot AI Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a generic concurrency group name 'main' will prevent workflows across different triggers (e.g., merge and release) from running concurrently. Consider incorporating the workflow name and/or branch in the group expression (e.g., ${{ github.workflow }}-${{ github.ref }}) to scope locks per workflow.

Suggested change
group: main
group: ${{ github.workflow }}-${{ github.ref }}

Copilot uses AI. Check for mistakes.
Copy link
Collaborator Author

@mishraomp mishraomp Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is by design, dont want to run them parallel

cancel-in-progress: false
# This concurrency group ensures that only one workflow runs at a time for the main branch.
permissions:
id-token: write # This is required for requesting the JWT
contents: write # This is required for actions/checkout
Expand Down Expand Up @@ -30,12 +33,15 @@ jobs:
name: Retag Images
needs: [vars]
runs-on: ubuntu-24.04
strategy:
matrix:
package: [backend, migrations, frontend]
steps:
- name: retag
uses: shrink/actions-docker-registry-tag@f04afd0559f66b288586792eb150f45136a927fa # v4
with:
registry: ghcr.io
repository: ${{ github.repository }}
repository: ${{ github.repository }}/${{ matrix.package }}
target: test # this is the tag of the containers to deploy
tags: |
prod
Expand Down
Loading