Skip to content

chore(ci): provide non-default namespace to Helm deployers#2416

Merged
DerekRoberts merged 1 commit into
mainfrom
chore/ci/helmNonDefaultNamespaces
Jun 16, 2025
Merged

chore(ci): provide non-default namespace to Helm deployers#2416
DerekRoberts merged 1 commit into
mainfrom
chore/ci/helmNonDefaultNamespaces

Conversation

@DerekRoberts
Copy link
Copy Markdown
Member

@DerekRoberts DerekRoberts commented Jun 16, 2025

Provide non-default namespace to Helm deployments. Best practice, prevents GitHub alerts.


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copilot AI review requested due to automatic review settings June 16, 2025 17:20
@DerekRoberts DerekRoberts self-assigned this Jun 16, 2025
@DerekRoberts DerekRoberts moved this from New to Active in DevOps (NR) Jun 16, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an explicit namespace setting for both frontend and backend Helm deployments so they deploy into the non-default namespace specified by the Helm release.

  • Added a namespace field in the frontend deployment template
  • Added a namespace field in the backend deployment template

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File Description
charts/app/templates/frontend/templates/deployment.yaml Added explicit namespace using {{ .Release.Namespace }}
charts/app/templates/backend/templates/deployment.yaml Added explicit namespace using {{ .Release.Namespace }}
Comments suppressed due to low confidence (2)

charts/app/templates/frontend/templates/deployment.yaml:6

  • Explicitly setting the namespace here is good practice. Please verify that using '{{ .Release.Namespace }}' consistently supports the overall deployment strategy.
namespace: {{ .Release.Namespace }}

charts/app/templates/backend/templates/deployment.yaml:6

  • Explicitly setting the namespace here is good practice. Please verify that using '{{ .Release.Namespace }}' consistently supports the overall deployment strategy.
namespace: {{ .Release.Namespace }}

@DerekRoberts DerekRoberts linked an issue Jun 16, 2025 that may be closed by this pull request
@DerekRoberts DerekRoberts enabled auto-merge (squash) June 16, 2025 17:26
@DerekRoberts DerekRoberts requested a review from mishraomp June 16, 2025 17:32
@DerekRoberts DerekRoberts disabled auto-merge June 16, 2025 17:39
@DerekRoberts DerekRoberts merged commit a8fcb93 into main Jun 16, 2025
31 checks passed
@DerekRoberts DerekRoberts deleted the chore/ci/helmNonDefaultNamespaces branch June 16, 2025 17:40
@github-project-automation github-project-automation Bot moved this from Active to Done in DevOps (NR) Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

chore: non-default namespace for Helm deploys

2 participants