Merged
Conversation
Fosol
reviewed
Aug 21, 2025
|
|
||
| /// <summary> | ||
| /// Retry Elasticsearch query once after 200ms to handle intermittent failures. | ||
| /// This helps resolve issues like JSON parsing failures in BC Updates filtering. |
Collaborator
There was a problem hiding this comment.
It's not clear why retrying here would resolve the issue. I like the retry.
Collaborator
Author
There was a problem hiding this comment.
I find it difficult to reproduce the issue, but the result was pointed to the ES.
Fosol
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users reported seeing blank report when this option is enabled. However, I don't believe this option is the actual cause. After testing dozens of times, the issue only occurred once, and I've been receiving automated reports for months without seeing any blank reports caused by enabling this option.
I believe this is an error that occurs when Elasticsearch is under heavy load. Therefore, I've added a retry mechanism to give the system time to recover.