Tenant UI frontend ESLint 9 upgrade #1660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
Deployment URLs ready for review. |
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the frontend linting system to ESLint 9 while maintaining the existing codebase functionality. The upgrade involves migrating from legacy ESLint configuration to the new flat config format, updating dependencies, and addressing various ESLint-related warnings.
Key changes include:
- Migration from ESLint 8 to ESLint 9 with flat configuration format
- Removal of unused imports and variables to address new linting rules
- Minor type corrections from
Stringtostringfor consistency - Update of package dependencies to their latest compatible versions
Reviewed Changes
Copilot reviewed 39 out of 44 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| services/tenant-ui/package.json | Updates ESLint and related dependencies to version 9 |
| services/tenant-ui/frontend/package.json | Updates frontend dependencies and removes legacy cross-env usage |
| services/tenant-ui/frontend/eslint.config.js | New flat ESLint configuration file with TypeScript and Vue support |
| services/tenant-ui/frontend/.eslintignore | Removes legacy ignore file (rules moved to config) |
| Multiple test files | Removes unused imports like beforeEach, expect, flushPromises |
| Multiple source files | Removes unused imports and variables, adds underscore prefixes |
| services/tenant-ui/frontend/src/types/index.ts | Corrects String to string type |
Files not reviewed (2)
- services/tenant-ui/frontend/package-lock.json: Language not supported
- services/tenant-ui/package-lock.json: Language not supported
services/tenant-ui/frontend/src/components/issuance/schemas/checkSchemaPostedInterval.ts
Show resolved
Hide resolved
...nant-ui/frontend/src/components/issuance/credentialDefinitions/checkCredDefPostedInterval.ts
Show resolved
Hide resolved
loneil
changed the title
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
jamshale
approved these changes
Jul 22, 2025
Contributor
jamshale
left a comment
jamshale
left a comment
There was a problem hiding this comment.
I just scanned over this but looked like you knew what you were doing.
esune
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the Tenant UI frontend to ESLint version 9 setup. Adjust some lint fixes across many files that were not detected in previous setup but should have been. (pretty much all the changes under /src or /test are just removing unused imports or minor type tweaks so can probably ignore those in a review)
Also in this PR regenerate the acapyInterface TS types from ACA-Py 1.3.1