Skip to content

TSConfig test fix#5580

Merged
brettedw merged 1 commit into
mainfrom
task/tsconfig-test-fixes
Jul 2, 2026
Merged

TSConfig test fix#5580
brettedw merged 1 commit into
mainfrom
task/tsconfig-test-fixes

Conversation

@brettedw

@brettedw brettedw commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Fixes tsconfig setup. Typescript was ignoring test files in dev, so during local development if you open a test file in the packages touched by this PR, you would see issues with test definitions like describe, it, and expect saying something like:

Cannot find name 'describe'. Do you need to install type definitions for a test runner? Try npm i --save-dev @types/jest or npm i --save-dev @types/mocha and then add 'jest' or 'mocha' to the types field in your tsconfig.

This was incorrect advice for the fix, the real reason was that typescript was ignoring test files in dev. This specifically adds a tsconfig.build.json for each package that ignores test files during builds.

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireCalc
FireCalc bookmark
Auto Spatial Advisory (ASA)
HFI Calculator
SFMS Insights
Fire Watch
Weather Toolkit

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.05%. Comparing base (cc66c5e) to head (c547b28).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5580   +/-   ##
=======================================
  Coverage   67.05%   67.05%           
=======================================
  Files         382      382           
  Lines       22686    22686           
  Branches     3101     3101           
=======================================
  Hits        15211    15211           
  Misses       6311     6311           
  Partials     1164     1164           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brettedw brettedw requested a review from conbrad June 30, 2026 23:08
@brettedw brettedw temporarily deployed to production July 2, 2026 15:16 Inactive
@brettedw brettedw merged commit 4a4659d into main Jul 2, 2026
36 checks passed
@brettedw brettedw deleted the task/tsconfig-test-fixes branch July 2, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants