Add Dockerfile #44
Merged
Add Dockerfile #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattSurabian
force-pushed
the
Dockerfile
branch
from
a970ed5 to
a63ee03
Compare
Contributor
Author
|
Pulling out CI fixes into a different PR #45 |
MattSurabian
force-pushed
the
Dockerfile
branch
from
736a661 to
ae750e6
Compare
MattSurabian
force-pushed
the
Dockerfile
branch
from
3977800 to
7a43c58
Compare
Owner
|
Thanks @MattSurabian! Yeah, I'll look at hooking up the automated build to docker hub after merging this. Had the plan to do a refactor and get everything into python3 but this would be a quicker step in the interim while I've got time now 😄 |
Owner
|
@MattSurabian have set it up now: https://hub.docker.com/r/bchew/dynamodump/ |
Contributor
Author
|
Nice thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Dockerfile so this project can be linked on Dockerhub like this https://hub.docker.com/r/mattsurabian/dynamodump/.
Love this script but ran into trouble using it on a team where everyone had slightly different Python setups and experience debugging perms issues on pip install. Much easier to farm the work out to an ephemeral container.
If this is something you're open to adding to the project I'll definitely unpublish my image from hub and direct to the canonical one.
Thanks for a great utility.