Skip to content

Conversation

@charlesknipe
Copy link
Contributor

This corrects the issue where even when passing --skipThroughputUpdate the utility will still attempt to adjust the provisioned capacity of the table during restore.

This is particularly important when working with tables that are configured for On Demand billing, as the throughput updates will not succeed.

@iksnae
Copy link

iksnae commented Oct 11, 2019

@charlesknipe Thank you so much for submitting this! i'm not sure what's failing on the CI build, but it worked exactly as expected.

@teamclicker
Copy link

@charlesknipe thanks for this!

@entropyjx
Copy link

entropyjx commented Dec 10, 2019

@charlesknipe Thank you for this fix!

I think CICD is failing due to flake8, some blank lines not following style standards, please check the cicd logs for specific lines.

And if possible, please fix it, once CICD passes, I believe the PR would be accepted.

I think this PR is very important, and should get merged into the master branch as soon as possible, the master branch is currently broken for restores on ON DEMAND dynamo db tables.

Copy link
Owner

@bchew bchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @charlesknipe

@bchew bchew merged commit 17015b9 into bchew:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants