Add functionality to add output in <head> tag for Profiler#3858
Closed
kenjis wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Kenji Suzuki <kenji.uui@gmail.com>
Contributor
|
Well, if you extend the profiler, you might as well extend the Output class too ... Sorry, I just don't see this as something that would be useful to many people, and it makes the coupling between CI_Profiler and CI_Output even stronger, which we should be avoiding. |
Contributor
Author
|
I want to add But I understood the coupling we avoid. Do you think we can do something to add To loose coupling between CI_Profiler and CI_Output, It seems we have to change the API. |
Contributor
|
Read through the discussion on #3847 ... it's all in there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you extends Profiler or use thrid-party profiler, you may want to add HTML for profiler in tag.
This PR provides such functionality.