Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs cleanup by removing dead code and optimizing the default check target. It removes an empty sys.version_info conditional block from the type stub file and reorganizes the justfile to separate slow checks from the standard check workflow.
Changes:
- Removed empty if-else block checking
sys.version_info >= (3, 11)from type stub file - Moved
check-docs-linksfrom defaultchecktarget tocheck-allonly (documented as slow)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/enum_properties/init.pyi | Removed empty version check block that served no purpose |
| justfile | Moved slow check-docs-links from check to check-all target only |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.