Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
===========================================
+ Coverage 99.22% 100.00% +0.77%
===========================================
Files 1 1
Lines 385 385
Branches 84 84
===========================================
+ Hits 382 385 +3
+ Misses 1 0 -1
+ Partials 2 0 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds targeted unit tests to improve branch coverage around EnumProperties’ functional API input parsing and annotation-driven property handling.
Changes:
- Add a functional-API test covering
namesprovided as an empty generator withproperties=.... - Add an annotations test ensuring a plain (non-symmetric)
name: ...annotation is ignored for property creation and does not alter default name-based lookup behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/test_functional.py |
Adds coverage for the non-sequence iterable (generator) empty-names path in the functional API with properties. |
tests/annotations/test.py |
Adds coverage for the annotation path where name is annotated without Symmetric, ensuring it’s ignored for property creation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.