Skip to content

Use require.resolve instead of require to avoid executing code. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bcoe merged 1 commit into from
Jul 8, 2016
Merged

Use require.resolve instead of require to avoid executing code. #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ module.exports = function (packages, _options, cb) {
}, _options)

async.eachLimit(packages, 1, function (arg, next) {
var pkg = arg.substr(0, arg.indexOf('@')) || arg
var pkg = arg.split('@')[0]
try {
// TODO: Either skip this part if a version has been provided or check the package json version
require(pkg)
require.resolve(pkg)
return next()
} catch (err) {
var child = spawn('npm', ['install', arg], {stdio: options.stdio})
Expand Down