Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
There was a problem hiding this comment.
Pull request overview
This pull request implements two major features: migration from postVars to global.data.js and progressive rebuilding in watch mode.
Changes:
- Replaces the
postVarspattern with a newglobal.data.jsfile that runs once per build after page initialization to aggregate data from all pages - Implements progressive rebuild logic in watch mode using dependency tracking to rebuild only affected pages/templates when files change
- Adds
@11ty/dependency-tree-typescriptdependency for static ESM dependency analysis
Reviewed changes
Copilot reviewed 17 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
types/@11ty__dependency-tree-typescript.d.ts |
Type definitions for the new dependency tree analysis package |
tsconfig.json |
Added custom type roots to include new type definitions |
package.json |
Added @11ty/dependency-tree-typescript dependency |
test-cases/general-features/src/page.vars.js |
Removed postVars implementation |
test-cases/general-features/src/global.data.js |
New global.data.js implementation demonstrating blog post aggregation |
test-cases/general-features/index.test.js |
Added test assertions for global.data output |
lib/identify-pages.js |
Added globalData detection, exported constants for watch mode, added trailing commas for consistency |
lib/identify-pages.test.js |
Added optional chaining for safer array access |
lib/helpers/dom-stack-warning.js |
Added DOM_STACK_WARNING_DUPLICATE_GLOBAL_DATA warning code |
lib/build-pages/resolve-vars.js |
Added resolveGlobalData function, replaced postVars support with migration error |
lib/build-pages/page-data.js |
Removed postVars support, added globalDataVars field |
lib/build-pages/worker.js |
Pass opts to buildPagesDirect for filtered rebuilds |
lib/build-pages/index.js |
Added GlobalDataFunction types, filter options, global.data integration pipeline |
lib/build-esbuild/index.js |
Refactored for watch mode support with stable filenames, added conflict detection for browser vars vs define |
index.js |
Implemented progressive rebuild watch mode with decision tree and dependency maps |
README.md |
Updated documentation for global.data.js, removed postVars references, added examples |
plans/progressive-rebuild.md |
Implementation plan for progressive rebuild feature |
plans/global-data.md |
Implementation plan for global.data feature |
.claude/settings.local.json |
Updated allowed bash commands |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ca15927 to
5033593
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 27 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
009f367 to
4fed229
Compare
See plans for details.