Conversation
Owner
|
Hi @stevet40, thanks for this. The comments look good. I think in general we'll only want to keep a 'most current' version so I could imagine removing the These are very high resolution! Not sure how necessary it all is, maybe time to actually implement #8 |
Contributor
Author
Owner
|
LGTM |
Owner
|
Thanks @stevet40 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This solves #46 for now.
I've added the v1.9 total throughputs for LSST from this repo:
https://github.com/lsst/throughputs/tree/main/baseline
I converted the wavelength column to Ångstroms. I added some comments to the top of the files to describe my understanding of these transmission curves. I think it's possible the recommended curves will change at some point, but hopefully these are okay for now. Let me know if you think I should add more detail in the comments at the tops of the files.