Add handling for HTTP 201 server responses#118
Merged
Conversation
Owner
|
v1.3.0-beta.1 release is out for testing. |
This was referenced Jun 26, 2023
Contributor
Author
|
I tested pinging via UUID and via slug with the linux-amd64, linux-arm, linux-arm64, and windows-amd64 builds, no issues. On the Healthchecks side, I had to make check auto-provisioning opt-in to preserve backwards compatibility. To enable auto-provisioning, the client must add a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since very recently, Healthchecks can return a HTTP 201 response to a ping request. Currently runitor treats HTTP 201 as non-retriable errors, this PR fixes that.