Skip to content

Remove build warnings#1

Merged
bdewey merged 10 commits intomainfrom
multiple-framework-experiment
May 24, 2022
Merged

Remove build warnings#1
bdewey merged 10 commits intomainfrom
multiple-framework-experiment

Conversation

@bdewey
Copy link
Copy Markdown
Owner

@bdewey bdewey commented May 24, 2022

We had hundreds of warnings from:

  1. Including header files from openssl / libssh in the built xcframework that weren't covered by the libgit2 umbrella header
  2. Not setting the right target SDK when building

Resolving #1 meant changing the build strategy. The dependencies are built into separate install directories, and then their resulting *.a files are all combined with libgit2.a. None of the dependent headers are now included in the framework.

@bdewey bdewey merged commit 9b73e42 into main May 24, 2022
@bdewey bdewey deleted the multiple-framework-experiment branch May 24, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant