Skip to content

ci: remove GHCR pushes and drop 386 builds from release workflow#32

Merged
bdk38 merged 2 commits intomainfrom
copilot/update-release-command-yml
Mar 8, 2026
Merged

ci: remove GHCR pushes and drop 386 builds from release workflow#32
bdk38 merged 2 commits intomainfrom
copilot/update-release-command-yml

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 8, 2026

The release workflow was pushing to both Docker Hub and GHCR (with duplicate login steps using both GITHUB_TOKEN and secrets.PAT), and was building unnecessary 386 targets.

Changes to .github/workflows/release-command.yml

  • Matrix: Remove "386" from goarch; now [amd64, arm64]. Drop the 386/darwin exclude entry; keep arm64/windows.
  • Docker metadata: Remove ghcr.io/bdk38/hellpot-community from images; Docker Hub only.
  • Login steps: Remove both GHCR login steps (GITHUB_TOKEN and secrets.PAT variants); keep Docker Hub login only.
  • Secret guard: Add early step that hard-fails if DOCKERHUB_USERNAME or DOCKERHUB_TOKEN are unset (skipped on pull_request events).
  • Permissions: Drop packages: write (no longer needed).
Original prompt

Make these changes to bdk38/HellPot repository in a single pull request:

  1. Update .github/workflows/release-command.yml
  • Remove GHCR (ghcr.io) from docker metadata images/tags so metadata only references Docker Hub image (bdk38/hellpot-community).
  • Remove both GHCR login steps that use GITHUB_TOKEN or secrets.PAT; keep only the Docker Hub login step (uses secrets.DOCKERHUB_USERNAME and secrets.DOCKERHUB_TOKEN).
  • Add an early "Check required secrets" step that fails with a clear message if DOCKERHUB_USERNAME or DOCKERHUB_TOKEN are missing (only when not a pull_request event).
  • Keep the wangyoucao577/go-release-action build step and Docker Buildx steps, but ensure docker/metadata-action images list only contains bdk38/hellpot-community and tags do not include ghcr.io entries.
  • Remove ghcr.io tags from the workflow and simplify login logic so the workflow does not attempt to push to GHCR.
  • Remove the goarch value "386" from the matrix (so goarch: [amd64, arm64]) to avoid building 386 targets. Remove or adjust any exclude entries that reference "386".
  1. (Optional) If .github/workflows/release.yml references windows/386 builds or ghcr, update it similarly to remove 386 builds. However based on current files, only release-command.yml requires the 386 removal.

  2. Update workflow file header or comments if needed to document the change (brief one-line comment stating GHCR pushes removed and 386 builds removed).

Make a branch named "ci/remove-ghcr-and-386" and create a pull request targeting the default branch (main). The PR title should be: "ci: remove GHCR pushes and drop 386 builds from release workflow". The PR body should explain the changes, why they were made (avoid pushing to GHCR; wrong token confusion; reduce CI builds), and list which files were modified (.github/workflows/release-command.yml). Do not change other repository files.

Please create the branch, commit the updated .github/workflows/release-command.yml with the modifications described, push the branch, and open the pull request in the repository bdk38/HellPot.

This pull request was created from Copilot chat.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: bdk38 <244781262+bdk38@users.noreply.github.com>
Copilot AI changed the title [WIP] Update release-command.yml for Docker Hub integration ci: remove GHCR pushes and drop 386 builds from release workflow Mar 8, 2026
Copilot finished work on behalf of bdk38 March 8, 2026 20:55
@bdk38 bdk38 marked this pull request as ready for review March 8, 2026 20:57
Copilot AI review requested due to automatic review settings March 8, 2026 20:57
@bdk38
Copy link
Copy Markdown
Owner

bdk38 commented Mar 8, 2026

We'll at Windows 386 and GHCR later if someone requests it.

@bdk38 bdk38 merged commit 391c0f6 into main Mar 8, 2026
9 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the release-command GitHub Actions workflow to publish Docker images only to Docker Hub (dropping GHCR) and to reduce build matrix scope by removing 386 builds.

Changes:

  • Remove GHCR image metadata and GHCR login steps; publish Docker images to Docker Hub only.
  • Remove 386 from the build matrix (goarch now [amd64, arm64]) and adjust exclusions accordingly.
  • Add an early workflow step to fail fast when required Docker Hub secrets are missing (non-PR events).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +22 to +24
- name: Check required secrets
if: github.event_name != 'pull_request'
run: |
Copy link

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The if: github.event_name != 'pull_request' guard is redundant here because this workflow only runs on release and workflow_dispatch events (no pull_request trigger). Consider removing the condition for clarity (or add a pull_request trigger if you intend to support PR runs).

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants