ci: remove GHCR pushes and drop 386 builds from release workflow#32
Merged
ci: remove GHCR pushes and drop 386 builds from release workflow#32
Conversation
Co-authored-by: bdk38 <244781262+bdk38@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update release-command.yml for Docker Hub integration
ci: remove GHCR pushes and drop 386 builds from release workflow
Mar 8, 2026
bdk38
approved these changes
Mar 8, 2026
Owner
|
We'll at Windows 386 and GHCR later if someone requests it. |
There was a problem hiding this comment.
Pull request overview
Updates the release-command GitHub Actions workflow to publish Docker images only to Docker Hub (dropping GHCR) and to reduce build matrix scope by removing 386 builds.
Changes:
- Remove GHCR image metadata and GHCR login steps; publish Docker images to Docker Hub only.
- Remove
386from the build matrix (goarchnow[amd64, arm64]) and adjust exclusions accordingly. - Add an early workflow step to fail fast when required Docker Hub secrets are missing (non-PR events).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+22
to
+24
| - name: Check required secrets | ||
| if: github.event_name != 'pull_request' | ||
| run: | |
There was a problem hiding this comment.
The if: github.event_name != 'pull_request' guard is redundant here because this workflow only runs on release and workflow_dispatch events (no pull_request trigger). Consider removing the condition for clarity (or add a pull_request trigger if you intend to support PR runs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow was pushing to both Docker Hub and GHCR (with duplicate login steps using both
GITHUB_TOKENandsecrets.PAT), and was building unnecessary386targets.Changes to
.github/workflows/release-command.yml"386"fromgoarch; now[amd64, arm64]. Drop the386/darwin exclude entry; keeparm64/windows.ghcr.io/bdk38/hellpot-communityfromimages; Docker Hub only.GITHUB_TOKENandsecrets.PATvariants); keep Docker Hub login only.DOCKERHUB_USERNAMEorDOCKERHUB_TOKENare unset (skipped onpull_requestevents).packages: write(no longer needed).Original prompt
This pull request was created from Copilot chat.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.