Migrate to built in kotlin for flutter 3.44#49
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the project to built-in Kotlin support, updates Android build configurations to target SDK 34, and refines Windows CMake scripts. Feedback highlights critical issues: the kotlin-android plugin and its classpath dependency were incorrectly removed from the plugin's build.gradle, which will break the build. Additionally, the pubspec.yaml files contain non-existent Dart and Flutter versions, and the gradle.properties flags for built-in Kotlin are currently disabled. Upgrading the outdated Android Gradle Plugin is also recommended.
Contributor
Author
|
I think gemini code assist is showing outdated information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the plugin to be consumed by projects using
android/generated by flutter 3.44see: https://docs.flutter.dev/release/breaking-changes/migrate-to-built-in-kotlin
Includes the fix from #48