Add developers using GitHub actions#11
Merged
bdougie merged 9 commits intobdougie:mainfrom Jul 9, 2020
Merged
Conversation
Add automation
add readme workflow
update action job name
damaneice
commented
Jul 9, 2020
| save ? readme.save! : (puts readme.preview) | ||
| end | ||
|
|
||
| update_readme(save: true) |
Contributor
Author
There was a problem hiding this comment.
If you need to run this script locally, setting the save flag to false will print the README to the console.
Owner
There was a problem hiding this comment.
good to know. I might add that note to the contributing.md
damaneice
commented
Jul 9, 2020
| def build_photo_grid(users) | ||
| lines = [] | ||
|
|
||
| users.map{|k, v| k}.each_slice(8) do |slice| |
Contributor
Author
There was a problem hiding this comment.
I just noticed the hardcoded 8 here. I think this needs to be changed. I will take a look at it later
Contributor
Author
There was a problem hiding this comment.
Never mine I think that is fine
Owner
There was a problem hiding this comment.
The 8 is hardcoded because that is the max that a gfm table will show without horizontal scroll
bdougie
reviewed
Jul 9, 2020
Owner
|
@damaneice thanks so much for the contribution. Open Source FTW my friend! |
bdougie
approved these changes
Jul 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR adds the ability to automatically add a new developer to the
READMEby creating an issue using the Add handle template.