Add UNITY_EDITOR constraint to HarmonyX and related packages#198
Merged
xoofx merged 1 commit intobdovaz:masterfrom May 10, 2023
Alexejhero:Alexejhero-patch-1
Merged
Add UNITY_EDITOR constraint to HarmonyX and related packages#198xoofx merged 1 commit intobdovaz:masterfrom Alexejhero:Alexejhero-patch-1
xoofx merged 1 commit intobdovaz:masterfrom
Alexejhero:Alexejhero-patch-1
Conversation
Contributor
Author
|
@bdovaz bump |
Contributor
Author
|
Can we get this PR merged and/or reviewed soon please? |
Owner
|
Already available in the new release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The packages added in #194 are used for runtime method patching, which only makes sense in an UNITY_EDITOR context.
(I spoke with @simonkellly before making this PR, his didn't know about
defineConstraintsand neither did I until I checked the issue log)