Skip to content

Add websocketsharp.core to registry#207

Merged
bdovaz merged 1 commit intobdovaz:masterfrom
forkercat:forkercat/add-websocketsharp-core
Jun 14, 2023
Merged

Add websocketsharp.core to registry#207
bdovaz merged 1 commit intobdovaz:masterfrom
forkercat:forkercat/add-websocketsharp-core

Conversation

@forkercat
Copy link
Copy Markdown
Contributor

This PR adds the websocketsharp.core package to the registry.

The NuGet package needs to respect a few constraints in order to be listed in the curated list:

  • Add a link to the NuGet package: https://www.nuget.org/packages/websocketsharp.core
  • It must have non-preview versions (e.g 1.0.0 but not 1.0.0-preview.1) - version provided: 1.0.0
  • It must provide .NETStandard2.0 assemblies as part of its package - version: >= .NETStandard2.0
  • The lowest version added must be the lowest .NETStandard2.0 version available
  • The package has been tested with the Unity editor - tested in my app in editor
  • The package has been tested with a Unity standalone player - tested in a server build
    • if the package is not compatible with standalone player, please add a comment to a Known issues section to the top level readme.md
  • All package dependencies with .NETStandard 2.0 target must be added to the PR - no dependencies
    • Note that if a future version of the package adds a new dependency, this dependency will have to be added manually as well

Note: The server will be updated only when a new version tag is pushed on the main branch, not necessarily after merging this pull-request.

@forkercat forkercat changed the title Add websocketsharp.core to regsitry Add websocketsharp.core to registry Jun 8, 2023
Signed-off-by: Junhao Wang <wjunhao@amazon.com>
@forkercat forkercat force-pushed the forkercat/add-websocketsharp-core branch from 1511573 to ec36568 Compare June 8, 2023 16:21
@forkercat
Copy link
Copy Markdown
Contributor Author

Hello @xoofx @bdovaz, greetings! This PR is ready for going through the workflow. Wanted to know if there are extra steps to get this change in. Thanks!

@forkercat
Copy link
Copy Markdown
Contributor Author

The workflow passed. This PR is ready for a merge.

@bdovaz bdovaz merged commit 401555c into bdovaz:master Jun 14, 2023
@forkercat
Copy link
Copy Markdown
Contributor Author

Hello @bdovaz, thanks for merging this PR in!

I noticed that the websocket still didn't show up in Package Manager. Does it mean something go wrong or I need to wait a bit?

@bdovaz
Copy link
Copy Markdown
Owner

bdovaz commented Jun 21, 2023

Already available in the new release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants