Skip to content

Align tab headers with document styling #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beNative merged 1 commit into from
Oct 4, 2025
Merged

Align tab headers with document styling #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/InfoView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ const InfoView: React.FC<InfoViewProps> = ({ settings }) => {
return (
<div className="flex-1 flex flex-col bg-background overflow-hidden min-h-0">
<header className="flex items-center justify-between px-4 h-7 border-b border-border-color bg-secondary flex-shrink-0">
<h1 className="text-xs font-semibold text-text-secondary tracking-[0.2em] uppercase">Application Information</h1>
<h1 className="text-xs font-semibold text-text-secondary tracking-wider uppercase">Application Information</h1>
<nav className="flex items-center gap-1">
{(Object.keys(docFiles) as DocTab[]).map(tab => (
<button
Expand Down
6 changes: 3 additions & 3 deletions components/LoggerPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@ const LoggerPanel: React.FC<LoggerPanelProps> = ({ isVisible, onToggleVisibility
onMouseDown={onResizeStart}
className="w-full h-1.5 cursor-row-resize flex-shrink-0 bg-border-color/50 hover:bg-primary transition-colors duration-200"
/>
<header className="flex items-center justify-between px-2 py-1.5 border-b border-border-color flex-shrink-0 gap-2">
<h3 className="text-[11px] font-semibold text-text-main">Application Logs</h3>
<header className="flex items-center justify-between px-2 h-7 border-b border-border-color bg-secondary flex-shrink-0 gap-2">
<h3 className="text-xs font-semibold text-text-secondary tracking-wider uppercase">Application Logs</h3>
<div className="flex items-center gap-1.5 flex-wrap justify-end">
<div className="flex items-center gap-1">
Comment on lines +122 to 125
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Allow logger header to grow when controls wrap

The new logger header uses a fixed height (h-7) while the control group on the right still allows wrapping (flex-wrap). On narrow viewports or when the Level buttons plus search input don’t fit in a single row, the second row is clipped behind the log content because the header can’t expand beyond 28 px. Previously the header height was driven by its content (py-1.5), so wrapped controls remained usable. Consider switching to min-h-7 or removing the hard height so wrapped controls remain visible.

Useful? React with 👍 / 👎.

<span className="text-[10px] text-text-secondary">Level:</span>
Expand All @@ -145,7 +145,7 @@ const LoggerPanel: React.FC<LoggerPanelProps> = ({ isVisible, onToggleVisibility
className="absolute right-1 top-1/2 -translate-y-1/2 text-[10px] text-text-secondary hover:text-text-main px-1"
aria-label="Clear log filter"
>
�
×
</button>
)}
</div>
Expand Down
14 changes: 7 additions & 7 deletions components/SettingsView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,17 +341,17 @@ const SettingsView: React.FC<SettingsViewProps> = ({

return (
<div className="flex-1 flex flex-col bg-background h-full">
<header className="flex justify-between items-center p-4 border-b border-border-color flex-shrink-0">
<h1 className="text-xl font-semibold text-text-main">Settings</h1>
<div className="flex flex-col items-end gap-1">
<Button onClick={handleSave} disabled={isSaveDisabled} variant="primary">
{isDirty ? 'Save Changes' : 'Saved'}
</Button>
<header className="flex items-center justify-between px-4 h-7 border-b border-border-color bg-secondary flex-shrink-0">
<h1 className="text-xs font-semibold text-text-secondary tracking-wider uppercase">Settings</h1>
<div className="flex items-center gap-2">
{pythonValidationError && (
<p className="text-[10px] text-destructive-text max-w-xs text-right">
<p className="text-[10px] text-destructive-text max-w-xs text-right leading-tight">
Python settings error: {pythonValidationError}
</p>
)}
<Button onClick={handleSave} disabled={isSaveDisabled} variant="primary" className="whitespace-nowrap">
{isDirty ? 'Save Changes' : 'Saved'}
</Button>
</div>
</header>
<div className="flex-1 flex overflow-hidden">
Expand Down