Fix release asset bundling for auto-updater #68
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [[ -d artifacts/windows-ia32-artifacts ]]; then | ||
| for file in artifacts/windows-ia32-artifacts/*.exe; do | ||
| base="$(basename "$file")" | ||
| ext="${base##*.}" | ||
| stem="${base%.$ext}" | ||
| cp "$file" "release_upload/${stem}-ia32.${ext}" | ||
| done | ||
| for file in artifacts/windows-ia32-artifacts/*.exe.blockmap; do | ||
| base="$(basename "$file")" | ||
| cp "$file" "release_upload/${base/.exe/-ia32.exe}" |
There was a problem hiding this comment.
The new packaging step unconditionally copies each windows-ia32-artifacts/*.exe and .exe.blockmap into release_upload with an extra -ia32 appended (cp "$file" "release_upload/${stem}-ia32.${ext}"). When Electron Builder already emits files such as *-ia32.exe and the accompanying latest.yml references those names, this produces *-ia32-ia32.exe artifacts while latest-ia32.yml still advertises the original *-ia32.exe. IA32 clients consuming the feed will therefore request a file that no longer exists and their auto-update will fail. Either skip renaming when the filename already contains the architecture suffix, or adjust the manifest contents to the new names.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68f35c7126a88332a13ffb4f090d9e1c