Skip to content

Fix release asset bundling for auto-updater #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2025
Merged

Fix release asset bundling for auto-updater #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 64 additions & 10 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,71 @@ jobs:
uses: actions/download-artifact@v4
with:
pattern: "*-artifacts"
path: dist
merge-multiple: true
path: artifacts
merge-multiple: false

- name: Prepare release assets
shell: bash
run: |
set -euo pipefail
shopt -s nullglob

mkdir -p release_upload

# --- Windows (x64) ---
if [[ -d artifacts/windows-x64-artifacts ]]; then
for file in artifacts/windows-x64-artifacts/*.exe; do
cp "$file" release_upload/
done
for file in artifacts/windows-x64-artifacts/*.exe.blockmap; do
cp "$file" release_upload/
done
if [[ -f artifacts/windows-x64-artifacts/latest.yml ]]; then
cp artifacts/windows-x64-artifacts/latest.yml release_upload/latest.yml
fi
fi

# --- Windows (ia32) ---
if [[ -d artifacts/windows-ia32-artifacts ]]; then
for file in artifacts/windows-ia32-artifacts/*.exe; do
base="$(basename "$file")"
ext="${base##*.}"
stem="${base%.$ext}"
cp "$file" "release_upload/${stem}-ia32.${ext}"
done
for file in artifacts/windows-ia32-artifacts/*.exe.blockmap; do
base="$(basename "$file")"
cp "$file" "release_upload/${base/.exe/-ia32.exe}"
Comment on lines +125 to +134
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Renaming IA32 installers breaks manifest references

The new packaging step unconditionally copies each windows-ia32-artifacts/*.exe and .exe.blockmap into release_upload with an extra -ia32 appended (cp "$file" "release_upload/${stem}-ia32.${ext}"). When Electron Builder already emits files such as *-ia32.exe and the accompanying latest.yml references those names, this produces *-ia32-ia32.exe artifacts while latest-ia32.yml still advertises the original *-ia32.exe. IA32 clients consuming the feed will therefore request a file that no longer exists and their auto-update will fail. Either skip renaming when the filename already contains the architecture suffix, or adjust the manifest contents to the new names.

Useful? React with 👍 / 👎.

done
if [[ -f artifacts/windows-ia32-artifacts/latest.yml ]]; then
cp artifacts/windows-ia32-artifacts/latest.yml release_upload/latest-ia32.yml
fi
fi

# --- macOS ---
if [[ -d artifacts/macos-artifacts ]]; then
for pattern in "*.dmg" "*.dmg.blockmap" "latest-mac*.yml"; do
for file in artifacts/macos-artifacts/$pattern; do
cp "$file" release_upload/
done
done
fi

# --- Linux variants ---
for dir in linux-x64-artifacts linux-arm64-artifacts linux-armv7l-artifacts; do
if [[ -d artifacts/$dir ]]; then
for pattern in "*.AppImage" "*.deb" "latest-linux*.yml"; do
for file in artifacts/$dir/$pattern; do
cp "$file" release_upload/
done
done
fi
done

shopt -u nullglob

- name: List files to upload (debug)
run: ls -alR dist
run: ls -alR release_upload

- name: Create/Update GitHub Release
uses: softprops/action-gh-release@v2
Expand All @@ -112,13 +172,7 @@ jobs:
draft: false
prerelease: false
files: |
dist/*.exe
dist/*.exe.blockmap
dist/*.dmg
dist/*.dmg.blockmap
dist/*.AppImage
dist/*.deb
dist/latest*.yml
release_upload/**
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}