Skip to content

Improve release manifest validation and updater diagnostics#94

Merged
beNative merged 1 commit into
mainfrom
codex/implement-ci-checks-for-release-integrity
Nov 11, 2025
Merged

Improve release manifest validation and updater diagnostics#94
beNative merged 1 commit into
mainfrom
codex/implement-ci-checks-for-release-integrity

Conversation

@beNative
Copy link
Copy Markdown
Owner

Summary

  • fail release builds when latest*.yml manifests are missing and normalize win32 artifact names before publishing
  • expand GitHub provider fallback to treat 404s as missing metadata and emit richer update-status diagnostics
  • document the manual manifest verification step and cover new behaviors with automated tests

Testing

  • npm test

Codex Task

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +34 to +37
const entries = await fs.readdir(releaseDir);
const ia32Executables = entries.filter(name => /-ia32-/i.test(name) && name.endsWith('.exe'));
if (ia32Executables.length === 0) {
log('No ia32 Windows executables detected; nothing to normalize.');
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Normalize all ia32 artifacts, not only ones containing "-ia32-"

The new normalization script only renames files whose names match /-ia32-/ before copying them into the release. Electron Builder’s Windows ia32 output often lacks that exact substring (e.g. GitAutomationDashboard Setup 0.25.9.exe or Foo-ia32.exe), so the script logs “No ia32 Windows executables detected; nothing to normalize.” and leaves filenames unchanged. Because the workflow step that previously appended -win32 was removed, win32 and x64 installers can now share identical filenames when published, causing the later copy step to overwrite one architecture’s binaries and manifests. The script should handle any ia32 build output (including names without a trailing hyphen) to ensure every win32 artifact is renamed to a unique *-win32* name.

Useful? React with 👍 / 👎.

@beNative beNative merged commit b948a81 into main Nov 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant