Improve release manifest validation and updater diagnostics#94
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const entries = await fs.readdir(releaseDir); | ||
| const ia32Executables = entries.filter(name => /-ia32-/i.test(name) && name.endsWith('.exe')); | ||
| if (ia32Executables.length === 0) { | ||
| log('No ia32 Windows executables detected; nothing to normalize.'); |
There was a problem hiding this comment.
Normalize all ia32 artifacts, not only ones containing "-ia32-"
The new normalization script only renames files whose names match /-ia32-/ before copying them into the release. Electron Builder’s Windows ia32 output often lacks that exact substring (e.g. GitAutomationDashboard Setup 0.25.9.exe or Foo-ia32.exe), so the script logs “No ia32 Windows executables detected; nothing to normalize.” and leaves filenames unchanged. Because the workflow step that previously appended -win32 was removed, win32 and x64 installers can now share identical filenames when published, causing the later copy step to overwrite one architecture’s binaries and manifests. The script should handle any ia32 build output (including names without a trailing hyphen) to ensure every win32 artifact is renamed to a unique *-win32* name.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task