Conversation
Redesigned `daw::poly_value` to use an internal storage abstraction, removing reliance on raw pointers and function-based copying. This change consolidates type safety, ensures better resource management, and reduces API complexity. Updated tests accordingly to align with the revised implementation.
Methods involving unchecked operations were renamed to include "_unsafe" in their names.
Renamed `type` to `value_type` and added clearer type aliases for `daw::constant` that are closer to `std::integral_constant`. Updated related static assertions and deprecated the `_c` literal in favor of `constant_v`.
Updated the `constant` template and its members to use `decltype(auto)` for improved type deduction and flexibility. Removed the deprecated user-defined literal operator and related code.
Replaced `decltype(auto)` with `auto` for both the template parameter and the `value` member.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added more numeric_limits template variables like max_value