Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
canReachtest.Description
table.sortbased priority queue with a binary heap implementation inmin.luausingsiftUp/siftDownand apriority(state)helper. (min.lua)M.setBounds,isInteger, andsafePowhelpers tostates.lua, and wire bounds fromknockout.luaviastates.setBounds(TARGET_MIN, TARGET_MAX). (states.lua,knockout.lua)opsto includea^bandb^ausingsafePow, and make division return only exact integer quotients (a % b == 0/b % a == 0). (states.lua)M.calcemits only integer results and deduplicates results per operand pair to avoid creating duplicate next states. (states.lua)M.canReachso it returnstruewhen bounds are missing, rejects invalid bounds, and uses a conservative interval (-sumAbs, sumAbs) to check potential reachability. (states.lua)Testing
lua knockout.lua 1 36 5 6 11to validate behavior, but the run failed becauseluais not available in the execution environment; no automated runtime tests could be completed.Codex Task