Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
flow_field.xmlupdate live when the bg HSV sliders are moved.Description
ProgressCallbackinterface and optional callback support toSliderBindingvia a new constructor andsetProgressCallback, and invoke it fromonProgressChangedin the slider listener.LogSliderBindingso logarithmic sliders can also trigger external listeners.HSVSliderGroupto accept anHSVChangeListener, store individualSliderBindinginstances, register per-sliderProgressCallbacks that compute combined HSV withgetValue, and call theHSVChangeListeneron changes.FlowFieldActivityto pass a lambda toHSVSliderGroupthat calls a newupdateBgColorPreviewhelper which sets thebgColorPreviewbackground withColor.HSVToColor, and add the necessary import.Testing
Codex Task