Skip to content
This repository was archived by the owner on Dec 27, 2022. It is now read-only.

DatArchive.selectArchive#501

Merged
pfrazee merged 24 commits intomasterfrom
dat-picker
Jun 4, 2017
Merged

DatArchive.selectArchive#501
pfrazee merged 24 commits intomasterfrom
dat-picker

Conversation

@taravancil
Copy link
Copy Markdown
Contributor

@taravancil taravancil commented Jun 4, 2017 •
edited by pfrazee
Loading

This adds:

  • A new DatArchive method, selectArchive(), which prompts the user to select or create an archive and returns the URL of the selected archive
  • A new modal for selecting an archive
var archive = await DatArchive.selectArchive({
  title: "Pick the archive you'd like to edit",
  buttonLabel: "Edit",
  filters: {writable: true}
})

screen shot 2017-06-04 at 1 11 55 pm

screen shot 2017-06-04 at 1 11 31 pm

taravancil added 24 commits June 2, 2017 19:40
@taravancil
Set up dat picker modal
7685100
@taravancil
Set up DatArchive.selectArchive API method
f0c28d0
@taravancil
Fix filtering
036fb23
@taravancil
Add functionality for submitting the form
026e4d4
@taravancil
Remove TODO, yes that is what we want to return
ba3ffd5
@taravancil
Handle select archive modal options
efb7346
@taravancil
Add select archive modal css
e9d8a14
@taravancil
Use title instead of message
db4e6d9
@taravancil
Add tabs element to the select archive modal
87d0860
@taravancil
Update dat picker styles
e1406f6
@taravancil
Switch all modal titles to h1s
e9a307f
@taravancil
Move placeholder styles to main modal stylesheet
6df6cfb
@taravancil
Put border on all archives so the search result has a border
27da6df
@taravancil
Add search icon to the dat picker search input
59d9ab5
@taravancil
Indicate if archive is read-only in dat picker
e7bdcab
@taravancil
Add titles to title and path
018fd84
@taravancil
Add overflow ellipsis for titles + path element
b0dcc0b
@taravancil
Remove butt lol
8abe473
@taravancil
Add writable option to filter out read-only archives
0fb4b05
@taravancil
Always return a dat:// URL, never just a key
e5d15de
@taravancil
Add tests for DatArchive.selectArchive
6c3ef26
@taravancil
Use opts.filters object instead of opts.writable
f7ab8ce
@taravancil
Add additional read-only indicator
020f89e
@taravancil
Make sure tab text doesn't jump around
74ebde0
@taravancil taravancil requested a review from pfrazee June 4, 2017 18:14
pfrazee
pfrazee approved these changes Jun 4, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👍 👍 👍

@pfrazee pfrazee merged commit 9ebc4d0 into master Jun 4, 2017
@pfrazee pfrazee deleted the dat-picker branch June 4, 2017 21:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@pfrazee pfrazee pfrazee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@taravancil @pfrazee