Merged
Conversation
mernit
approved these changes
Mar 11, 2026
Contributor
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="pkg/worker/nvidia.go">
<violation number="1" location="pkg/worker/nvidia.go:47">
P2: Preserve whether `NVIDIA_VISIBLE_DEVICES` was originally unset; using `Getenv` + unconditional `Setenv` can incorrectly create an empty env var.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Preserve
NVIDIA_VISIBLE_DEVICESduring CDI generation to preventvoidfrom hiding GPUs from the worker. Adds GPU discovery edge-case tests and improves allocation error messages.Bug Fixes
NVIDIA_VISIBLE_DEVICESaroundnvidia-ctk cdi generateso the worker’s env isn’t overwritten withvoid.NVIDIA_VISIBLE_DEVICES.AvailableGPUDevices: mismatched visibility, missing/procentries, procfs errors, and query failures.Dependencies
github.com/VictoriaMetrics/metricsandgithub.com/beam-cloud/blobcache-v2.github.com/opencontainers/runcandgithub.com/containerd/consoleto indirect; removedsdk/uv.lock.Written for commit 5b67b27. Summary will update on new commits.