Skip to content

second fix for gpu visibility issue#1553

Merged
luke-lombardi merged 1 commit intomainfrom
ll/gpu-fix-2
Mar 11, 2026
Merged

second fix for gpu visibility issue#1553
luke-lombardi merged 1 commit intomainfrom
ll/gpu-fix-2

Conversation

@luke-lombardi
Copy link
Copy Markdown
Contributor

@luke-lombardi luke-lombardi commented Mar 11, 2026

Summary by cubic

Fixes GPU discovery when NVIDIA_VISIBLE_DEVICES is set to "void" or empty by treating both as "all", ensuring workers see available GPUs. Also removes brittle env var juggling around CDI generation.

  • Bug Fixes
    • Treat "void" and empty NVIDIA_VISIBLE_DEVICES as "all" in GPU filtering.
    • Remove save/restore of NVIDIA_VISIBLE_DEVICES around nvidia-ctk cdi generate.
    • Add tests for "void" and empty env cases to confirm device visibility.

Written for commit e3e2cc8. Summary will update on new commits.

@luke-lombardi luke-lombardi requested a review from mernit March 11, 2026 16:32
@luke-lombardi luke-lombardi merged commit 51beead into main Mar 11, 2026
2 of 3 checks passed
@luke-lombardi luke-lombardi deleted the ll/gpu-fix-2 branch March 11, 2026 16:32
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants