Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes GPU visibility tests by removing brittle mocks and adding an opt-in integration test that runs on a real GPU node. Also caches the resolved NVIDIA_VISIBLE_DEVICES on the manager and uses it in error messages for consistent behavior.
Bug Fixes
chooseDevicesnow reports the resolved visible devices value from the manager, improving error clarity.New Features
gpu_integration_test.go(enable with GPU_INTEGRATION=1) to verify device resolution, per-worker isolation (exactly one GPU), and allocation behavior.Written for commit 66d007b. Summary will update on new commits.