different approach to fixing isolation bug#1556
Merged
luke-lombardi merged 1 commit intomainfrom Mar 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 6 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="pkg/worker/gpu_info.go">
<violation number="1" location="pkg/worker/gpu_info.go:68">
P2: This returns only one `DeviceIDs` map value, which can drop assigned GPUs when IDs are spread across multiple entries. Flatten all UUID slices before joining.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes GPU isolation by resolving the assigned GPU UUID from the kubelet device plugin checkpoint instead of PID 1 env. Workers now reliably select the correct GPU and avoid the
NVIDIA_VISIBLE_DEVICES=voidbug./var/lib/kubelet/device-plugins/kubelet_internal_checkpointto mapPOD_UIDtonvidia.com/gpuUUIDs, with fallback toNVIDIA_VISIBLE_DEVICES./var/lib/kubelet/device-pluginsread-only into worker pods in both external and local schedulers.POD_UIDinto worker env for lookup.Written for commit 95ea521. Summary will update on new commits.