Skip to content

fix v2 clip issue#1622

Merged
luke-lombardi merged 1 commit into
mainfrom
ll/fix-v2-issue
Jun 3, 2026
Merged

fix v2 clip issue#1622
luke-lombardi merged 1 commit into
mainfrom
ll/fix-v2-issue

Conversation

@luke-lombardi
Copy link
Copy Markdown
Contributor

@luke-lombardi luke-lombardi commented Jun 3, 2026

Summary by cubic

Disable embedded image archive cache for Clip v2 so image pulls always come from the registry, fixing incorrect restore behavior. Also improves cache restore paths and telemetry for clearer diagnostics.

  • Bug Fixes

    • Skip embedded image archive cache when ClipVersion2; continue using it for v1.
    • Stop emitting required-content events with an empty kind (ignore instead of defaulting).
  • Refactors

    • Split cache metadata lookup and restore; add wait path that restores using fetched metadata.
    • Add cache operation tracing and record detailed lifecycle attrs (hash, size, routing key, results).
    • writeImageArchiveFromContentCache now returns a trace and uses ReadContentIntoWithTrace.
    • Remove RequiredContentKindImageArchive.
    • Pass app config into WorkerRepositoryService via a new constructor argument.

Written for commit c00023a. Summary will update on new commits.

Review in cubic

@luke-lombardi luke-lombardi merged commit e65c139 into main Jun 3, 2026
4 checks passed
@luke-lombardi luke-lombardi deleted the ll/fix-v2-issue branch June 3, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants