fix v2 clip issue#1622
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Disable embedded image archive cache for Clip v2 so image pulls always come from the registry, fixing incorrect restore behavior. Also improves cache restore paths and telemetry for clearer diagnostics.
Bug Fixes
ClipVersion2; continue using it for v1.Refactors
writeImageArchiveFromContentCachenow returns a trace and usesReadContentIntoWithTrace.RequiredContentKindImageArchive.WorkerRepositoryServicevia a new constructor argument.Written for commit c00023a. Summary will update on new commits.